Merge branch '1.3' of ezsystems/ezplatform-kernel into 4.5 #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eting content For more details see https://issues.ibexa.co/browse/IBX-7485 and ezsystems/ezplatform-kernel#400 Key changes: * Skipped files with corrupted filenames when loading and deleting * [Tests] Added integration test
|
Status update: the bug still exists on 4.x, so investigating. |
alongosz
force-pushed
the
temp_1.3_to_4.5
branch
from
f4b774c to
de3f5a1
Compare
6 tasks
Steveb-p
approved these changes
Feb 1, 2024
konradoboza
approved these changes
Feb 1, 2024
ciastektk
approved these changes
Feb 1, 2024
Co-Authored-By: Paweł Niedzielski <[email protected]>
alongosz
force-pushed
the
temp_1.3_to_4.5
branch
from
de3f5a1 to
408552f
Compare
|
|
QA approved on IbexaDXP 4.5 commerce. |
tomaszszopinski
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cross merge PR of ezsystems/ezplatform-kernel#400
Seems with newer Flysystem it works OOTB.We're already catching FlysystemException which is parent for
CorruptedPathDetected. So, no changes are needed forloadmethod.Applied changes to
existsmethod with a requested change of loggingCorruptedPathDetectedocurrence.Testing needed some more creativity, because for 4.x we don't check
existsexplicitly. It's a side effect of calling\Ibexa\Core\FieldType\Image\AliasCleanerInterface::removeAliases. Integration test setup however has limited IO configuration, relying on\Ibexa\Core\FieldType\Image\NullAliasCleanerso the issue detected by QA wasn't showing in the test.Instead got from the Legacy setup factory container proper implementation of
IOServiceused by the production code and manually calledexists.Bonus: dropped unused and malformed Service definition:
ibexa.core.io.metadata_handler.flysystem. It's neither abstract nor would work when instantiated, because of incorrect argument list (visible only when explicitly trying to use it). Looks like a left-over after Flysystem upgrade.Requires further QA